nextcloud / nextcloud/server

Pressing escape on the sharing note should cancel and not save

Open
#18,935 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: sharing good first issue needs review papercut
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

We needed https://github.com/nextcloud/nextcloud-vue/pull/819 after https://github.com/nextcloud/server/pull/18894

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review nextcloud-vue PR #819 and server PR #18894 first, since the issue says those changes were needed. Confirm whether the sharing note still saves when Escape is pressed; done means Escape cancels the note without saving.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.