nextcloud / nextcloud/server

Don't disable apps for errors in unrelated code paths

Open
#18,249 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop feature: apps management technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Steps to reproduce
  1. Run Nextcloud
  2. Run into an unhandled exception during app initialization phase
  3. See unrelated apps getting disabled
Expected behaviour

We only disable apps if it's really their fault and the error was triggered there.

Actual behaviour

If apps call some other app's or server code and that causes an exception (database or redis down, for example) that app is wrongly disabled. Leading to other bugs and unwanted behavior.

Server configuration

Nextcloud version:

any


cc @blizzz @nickvergessen @rullzer

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the app initialization phase and reproduce an unhandled exception from an unrelated app or server path, such as a database or Redis failure. Trace how the exception causes apps to be disabled; done means only the app responsible for the error is disabled, while unrelated apps remain enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, redis
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.