nextcloud / nextcloud/server

Show deletion/creation of user via CardDAV in activity stream

Open
#16,974 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: activity and notification feature: carddav
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Steps to reproduce

I deleted an user on my phone and it synced with my server via CardDAV.

Expected behaviour

See the deletion of the user in the Activity stream.

Actual behaviour

Only the deletion of the birthday event from the Birthdays calendar is shown.

FEATURE REQUEST
Undo (user, event, ...) deletion from the Activity stream, because there’re all activities displayed and it was the logical place for undo an action like in other services (Dropbox, OneDrive, ...)

Server configuration detail

Operating system: Linux 3.13.0-170-generic #220-Ubuntu SMP Thu May 9 12:40:49 UTC 2019 x86_64

Webserver: Apache (fpm-fcgi)

Database: mysql 5.6.44

PHP version:

7.3.6-nmm1
Modules loaded: Core, date, libxml, openssl, pcre, zlib, bcmath, bz2, calendar, ctype, dom, hash, filter, ftp, gettext, SPL, iconv, json, mbstring, posix, Reflection, session, standard, shmop, SimpleXML, soap, exif, sysvsem, sysvshm, tokenizer, wddx, xml, xmlreader, xmlwriter, zip, cgi-fcgi, propro, raphf, http, mysqlnd, PDO, curl, dba, fileinfo, gd, gender, gmp, htscanner, imagick, imap, interbase, intl, ldap, mailparse, mongodb, mysqli, OAuth, odbc, pdo_dblib, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, Phar, pspell, recode, sodium, sqlite3, tidy, xsl, ionCube Loader

Nextcloud version: 16.0.4 - 16.0.4.1

Updated from an older Nextcloud/ownCloud or fresh install: 15.0.x

Where did you install Nextcloud from: unknown

Signing status

Array
(
)

List of activated apps
Enabled:
 - accessibility: 1.2.0
 - activity: 2.9.1
 - admin_audit: 1.6.0
 - apporder: 0.7.1
 - bruteforcesettings: 1.4.0
 - calendar: 1.7.0
 - cloud_federation_api: 0.2.0
 - comments: 1.6.0
 - contacts: 3.1.3
 - dav: 1.9.2
 - extract: 1.2.0
 - federatedfilesharing: 1.6.0
 - files: 1.11.0
 - files_antivirus: 2.1.1
 - files_pdfviewer: 1.5.0
 - files_rightclick: 0.15.1
 - files_sharing: 1.8.0
 - files_trashbin: 1.6.0
 - files_versions: 1.9.0
 - issuetemplate: 0.5.0
 - logreader: 2.1.0
 - lookup_server_connector: 1.4.0
 - notifications: 2.4.1
 - oauth2: 1.4.2
 - occweb: 0.0.4
 - password_policy: 1.6.0
 - privacy: 1.0.0
 - provisioning_api: 1.6.0
 - rainloop: 6.0.3
 - recommendations: 0.4.0
 - serverinfo: 1.6.0
 - sharebymail: 1.6.0
 - sharerenamer: 2.7.0
 - socialsharing_email: 1.0.5
 - support: 1.0.0
 - systemtags: 1.6.0
 - tasks: 0.11.1
 - theming: 1.7.0
 - twofactor_admin: 0.4.1
 - twofactor_backupcodes: 1.5.0
 - twofactor_totp: 3.0.1
 - updatenotification: 1.6.0
 - userimap: 0.0.1
 - viewer: 1.1.0
 - workflowengine: 1.6.0
Disabled:
 - activitydefaults
 - admin_notifications
 - checksum
 - deck
 - disablerememberlogin
 - encryption
 - external
 - federation
 - files_clipboard
 - files_external
 - files_snapshots
 - files_texteditor
 - files_videoplayer
 - firstrunwizard
 - gallery
 - nextcloud_announcements
 - onlyoffice
 - ransomware_protection
 - shorten
 - survey_client
 - suspicious_login
 - theme_switcher-2.1
 - twofactor_email
 - user_external
 - user_ldap
 - user_sql

Configuration (config/config.php)
{
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "MYDOMAIN.TLD"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "overwrite.cli.url": "https:\/\/MYDOMAIN.TLD",
    "overwriteprotocol": "https",
    "dbtype": "mysql",
    "version": "16.0.4.1",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "O39jE_",
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "logtimezone": "UTC",
    "installed": true,
    "imap_host": "MYDOMAIN.TLD",
    "imap_inHost": "XXXX.kasserver.com",
    "imap_inPort": 143,
    "imap_inSSL": "tls",
    "imap_outHost": "XXXX.kasserver.com",
    "imap_outPort": 587,
    "imap_outSSL": "tls",
    "imap_ud_host": "https:\/\/ud.MYDOMAIN.TLD",
    "user_backends": [
        {
            "class": "OC_User_IMAP_wUD",
            "arguments": [
                "{XXXX.kasserver.com:143}"
            ]
        }
    ],
    "appstore.experimental.enabled": true,
    "maintenance": false,
    "theme": "",
    "loglevel": 2,
    "updater.release.channel": "production",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpmode": "sendmail",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "tempdirectory": "\/www\/htdocs\/XXXX\/cloud\/STATIC_DATA_DIR\/tmp",
    "mail_sendmailmode": "pipe",
    "app_install_overwrite": [
        "mail",
        "occweb"
    ],
    "twofactor_enforced": "true",
    "twofactor_enforced_groups": [
        "Familie Herzog",
        "Gemeinsam sind wir stark"
    ],
    "twofactor_enforced_excluded_groups": []
}

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption: false

Are you using an external user-backend, if yes which one: IMAP

Client configuration

Browser: Safari 0.0

Operating system:

Logs

Web server error log
Insert your web server log here 
Nextcloud log
There’re only entries for Antivirus, so I don’t enter it here. 
Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the CardDAV synchronization path and the Activity stream handling for user and birthday-event deletions. The issue provides no source files or tests, so first identify the relevant entry points and clarify whether completion means recording user creation/deletion, supporting undo, or both.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.