nextcloud / nextcloud/server

Confirm modal: Exclamation mark out of place

Open
#15,778 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop 26-feedback design papercut technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

From: https://github.com/nextcloud/server/pull/15774#issuecomment-496557238

Looks a bit blurry to me, and ! is out of place?

@ChristophWurst

yes, but that is an issue with the confirm modal in general. mind opening a ticket for that and pinging our designers? thx

@nextcloud/designers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the confirm modal shown in the linked pull request and review the accompanying screenshot and design discussion. No source files or tests are named, so locate the modal implementation before confirming the intended punctuation placement and visual sharpness with the designers. Done means the modal's exclamation mark and appearance match the agreed design.

Written by the indexing model from the issue text.

Assessment

Domain
design, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.