nextcloud / nextcloud/server

Ability to set permissions before sharing

Open
#13,229 11 comments 10 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop client: 💻 desktop client: 🤖🍏 mobile design enhancement feature: sharing standardization
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Done

  • Android
  • iOS
  • Desktop
  • Web UI

In the past we often talked about one of the core issues of our very easy share flow: You basically share with edit permissions always, and have to adjust later. This results in a small window where people could change or delete stuff.

This proposal fixes this very simply by adding an indicator of the current setting in the sharing input:

  • ✏ Allow editing (default)
  • 👁️ Read-only

Now when you change this current setting, it could be remembered. Either for the session only, per file/folder or simply globally. We can discuss what’s best and most feasible.
sharing permissions

This is the code I used in the mockup (based on Personal settings federation dropdown ;), if anyone wants to start implementing it:


<div class="">
    <span class="icon-rename">
    	<span class="icon-triangle-s"></span>
    </span>
    <div class="popovermenu bubble menu menu-right">
        <ul>
        	<li>
        		<a href="#" class="menuitem permanent">
        				<span class="icon-rename"></span>
        			<p>
        				<strong class="menuitem-text">Allow editing</strong><br>
        				<span class="menuitem-text-detail">Recipients will be able to edit and reshare</span>
        			</p>
        		</a>
        	</li>
        	<li>
        		<a href="#" class="menuitem permanent">
        				<span class="icon-toggle"></span>
        			<p>
        				<strong class="menuitem-text">Read-only</strong><br>
        				<span class="menuitem-text-detail">Recipients will not be able to change anything</span>
        			</p>
        		</a>
        	</li>
        </ul>
    </div>
</div>

What do you think @nextcloud/designers @MorrisJobke @rullzer?

If we go forward with this, it’s also something we need to align in the desktop client and mobile apps: @nextcloud/ios @nextcloud/desktop @nextcloud/android

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation files, entry points, or tests are identified; start by reviewing the sharing input and the proposed permission choices in this issue. Before coding, resolve whether the setting applies to the session, each file or folder, or globally, and which Android, iOS, desktop, and web clients are in scope. Done requires an agreed design and consistent read-only or editing behavior across the selected clients.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
authorization, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.