Cleanup Server.php (aliases & services)
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
As discussed with @MorrisJobke
We regsiter a lot of plain text aliases like
https://github.com/nextcloud/server/blob/9319d557a4b1156d82d824cdb1b7d6f07ad3fbde/lib/private/Server.php#L182
They should all die. Services should be queries properly using their servicename.
Ideally we also remove as much simple wrappers as possible like:
https://github.com/nextcloud/server/blob/9319d557a4b1156d82d824cdb1b7d6f07ad3fbde/lib/private/Server.php#L256-L258
The DI can handle that all perfectly by itself when it is actually needed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/private/Server.php, especially the referenced alias block around line 182 and wrapper code around lines 256-258. Review the discussion context and identify the plain-text aliases and simple service wrappers targeted by this issue. Done means those aliases are removed, services are queried by servicename, and unnecessary wrappers are eliminated where DI handles them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100