nextcloud / nextcloud/server

Add "request new" button to password reset token expired error

Open
#10,776 12 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: authentication feature: users and groups needs review
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

If you create a user without password or use the password reset function, the user gets a mail with the reset link.
This link expires after 24h:
"Couldn't reset password because the token is expired"

For a password reset requested by the user, this is no problem, because the user normally uses the link after request.

But if you create a new user on friday and the user accesses the link on monday, this is a problem.

Why not just add a button to the password expired error, where the user can request a new reset link?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the password reset flow and the expired-token error described in the issue. Trace how the expired-link response is rendered and how a user can request a reset link, then verify that the new button requests another link and works for newly created users whose original link has expired.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.