LDAP: migrate/transform remaining integration test
Open
Nobody has claimed this yet.
enhancement
feature: ldap
overview
tests
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Follow up to https://github.com/nextcloud/server/pull/8855
Tests that still need to be migrated or transformed (because they ain't really integration tests…):
- IntegrationTestAttributeDetection.php
- IntegrationTestCountUsersByLoginName.php
- IntegrationTestFetchUsersByLoginName.php
- IntegrationTestPaging.php (partly)
- IntegrationTestUserHome.php
- User/IntegrationTestUserAvatar.php
- User/IntegrationTestUserCleanUp.php
- User/IntegrationTestUserDisplayName.php
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pull request 8855 and inspect the listed LDAP test files: IntegrationTestAttributeDetection.php, IntegrationTestCountUsersByLoginName.php, IntegrationTestFetchUsersByLoginName.php, IntegrationTestPaging.php, IntegrationTestUserHome.php, and the three User tests. Determine which tests should be migrated or transformed rather than remain integration tests; done means all listed items are handled and the LDAP test suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100