Add template renderas empty
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Richdocuments renders all their templates as empty. This is done because we embed the view in an iframe and we do not need the top bar etc etc.
This works because the old code never checks the render as value as being one of the valid ones.
I'd vote to make this an official mode. And then also make sure that we kill javascript that doesn't belong there (for example the search stuff).
CC: @nickvergessen @MorrisJobke
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing where template render-as values are validated and where the Richdocuments iframe view loads its JavaScript, especially the search-related code. Done means empty is accepted as an official mode and unrelated JavaScript is excluded from that embedded view.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100