nextcloud / nextcloud/server

Don't highlight mention of unknown user

Open
#10,021 7 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop design enhancement feature: comments papercut
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Follow up from here: https://github.com/nextcloud/spreed/issues/1006

This is what happens if I mention a user who doesn't exists in Talk:

talk - mention

I think instead we shouldn't format the mention and show it as a normal string. Imagine I want to tell someone I'm @schiessle on Twitter, this shouldn't be changed to I'm @UnknownUser at Twitter

Some additional thoughts from @jancborchardt :

Agree with @schiessle here. There’s some other cases additionally:

  • You simply have a typo in the username: @schiesle or @blizzzz would be completely made unreadable to @Unknown user, which is worse than showing them with a typo
  • The case of LDAP you bring up we can easily catch as the LDAP ID is a format we can parse. For those non-existent LDAP users we can indeed show @Unknown user
  • In the case where you do not use LDAP but Nextcloud user management and a user is deleted, then showing @Unknown user will make the context invisible too. With a non-marked-up @ivan you at least know who it was addressed too, even though they aren’t in the system anymore.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Talk mention-rendering entry point and review the linked issue #1006 for the existing behavior and context. Done means unknown mentions remain readable as ordinary text, while the issue's described LDAP exception is handled as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.