nextcloud / nextcloud/richdocuments
Link picker: pass a human-friendly `text` label to `Action_InsertLink`
Open
Beginner friendly
Nobody has claimed this yet.
enhancement
- Dominant language
- JavaScript
- Stars
- 453
- Forks
- 147
- Avg merge
- 14h 54m
- Merged PRs (30d)
- 83
Description
When a user inserts a link via the Smart Picker inside a Collabora Online document, the resulting hyperlink is labelled with the raw URL instead of the picked resource's name. Collabora Online now accepts an optional text field on Action_InsertLink (CollaboraOnline/online#15561.
| Action | Parameters______ | Description |
|---|---|---|
Action_InsertLink |
xmlurl: <String>text: <String> |
Insert a link into the document. This is usually the response to a successful UI_PickLink. Added in version 26.04 The optional text argument, if supplied, is used as the hyperlink label when the user has no text selected in the document. If a selection exists it takes precedence. When neither is available, the URL is used as the label. |
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the Smart Picker handling of the UI_PickLink response and the code that sends Action_InsertLink to Collabora Online. Pass the picked resource name as the optional text value, then verify that inserted links use that name when no document text is selected while selected text still takes precedence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100