nextcloud / nextcloud/richdocuments
Inform user that file insertion failed
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 453
- Forks
- 147
- Avg merge
- 14h 54m
- Merged PRs (30d)
- 83
Description
Is your feature request related to a problem? Please describe.
I heared many complaints from users who didn't manage to insert Image from the NC storage that "nothing happens".
It is a problem with using nginx proxy in front of NC what causes request to assests failed. In that case unfortunately there is no visible feedback for user what happened. After investigation it is FilePicker error. Best would be to check request status.
Describe the solution you'd like
It would be good to provide message dialog with error visible for user when file insertion failed.
Additional context
Related to: https://github.com/nextcloud/richdocuments/issues/4565
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/view/FilesAppIntegration.js around line 164 and inspect how FilePicker insertion failures are handled. Reproduce a failed image insertion through the nginx proxy, then add visible error feedback and verify that successful insertions remain unaffected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100