nextcloud / nextcloud/richdocuments
Admin settings file upload error
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 453
- Forks
- 147
- Avg merge
- 14h 54m
- Merged PRs (30d)
- 83
Description
Problem
A lot of legacy code was cleaned out of the server repository, and richdocuments still relies on a lot of legacy code, unfortunately. This breaks the admin settings a bit when it comes to the global templates settings, since it relies on a legacy file upload plugin that no longer exists on the master branch of the server repository. This is also causing failing tests on the main branch of richdocuments.
Solution
We clearly need to do the same and clean out the legacy code related to the admin settings, as it's quite a mess. The solution would be to rewrite the admin settings and make them more modular and maintainable, as right now it's one giant Vue component, with a lot of legacy code being used in the template as well, and using PHP as a sort of templating language there.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the admin settings implementation and the global templates settings, then inspect the failing tests on the main branch. Map the legacy upload and PHP-templating dependencies before deciding how to split the giant Vue component; done means the legacy code is removed, the settings remain functional, and the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100