nextcloud / nextcloud/richdocuments

Opening NC right menu from richdocuments is not possible if the user does not have sharing permission

Open
#3,334 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: share link
Dominant language
JavaScript
Stars
453
Forks
147
Avg merge
14h 54m
Merged PRs (30d)
83

Description

Describe the bug
Usually in Collabora, the following icons are shown at the top right of the editor.
image

The following one allows to open the sharing tab of the nextcloud files, and from the sharing tab, you can access the details, or the comments, or the chat and video tab, which is quite useful if you want to comment or have a call at the same time you edit the document.
image

Howewer, this icon is not present if the user cannot share the file. But even if the user cannot share the file, he might want to comment it, or have a call.
image

To Reproduce
Steps to reproduce the behavior:

  1. Create a folder (or a groupfolder) and an office document inside the folder
  2. Share this folder with Alice, and remove the reshare permission
  3. Log with Alice
  4. Open the office document from the shared folder
  5. Alice is not able to open the Nextcloud right menu
    image

Expected behavior
Even if the sharing permission is denied, Alice should be able to open the right side menu, as for any other document with sharing permission.

Screenshots
See above

Client details:

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
  • Device: [e.g. iPhone6, desktop]

Server details

t.nc.c
Operating system:

Web server:

Database:

PHP version:

Nextcloud version: 27.1.2

Version of the richdocuments app

Version of Collabora Online

Logs
Nextcloud log (data/nextcloud.log)
Insert your Nextcloud log here
Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by opening an office document as a user without reshare permission, then trace the richdocuments frontend entry point that decides whether the Nextcloud right menu icon is shown. Done means the user can open the right-side menu and access comments, details, chat, or video without gaining sharing permission.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authorization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.