nextcloud / nextcloud/registration

i18n: Two identical variables will not work in many languages

Open
#746 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
147
Forks
83
Avg merge
1d 2h
Merged PRs (30d)
9

Description

https://github.com/nextcloud/registration/blob/18802e3c76a760e54f3141bb08c29c8aebadae80/lib/Service/MailService.php#L160

Please replace with variable 1 and 2 to allow correct translation for all languages.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open lib/Service/MailService.php at line 160 and inspect how the two identical variables are used in the message. Replace them with distinct variables so translators can order both values independently, then verify the resulting message supports different translations.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
internationalization
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.