nextcloud / nextcloud/recommendations
Empty "Recommend files" dashboard widget distorts the layout of all widgets
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 15
- Forks
- 19
- Avg merge
- 6d 15h
- Merged PRs (30d)
- 9
Description
When the dashboard contains the "Recommend files" widget and there are no contents in the widget, all dashboard widgets become taller than they should. This may look ugly on some widgets as there are unexpected margins.
Here is the problem case:
The same with dimensions shown:
The problem goes away when the "Recommended files" gets any content (or is removed from the dashboard):
The same with dimensions shown:
The culprit seems to be the margin-top on the "No recommendations yet" label which affects the height of the entire widget. And somehow, this propagates to the other widgets, too.
I have seen this problem on Nextcloud 30.0.0 and 30.0.2-rc1 but not on 29.0.0-rc5.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the "No recommendations yet" label and its margin styling in the dashboard widget, then reproduce the layout with an empty "Recommend files" widget alongside other widgets. Confirm the fix by checking that empty recommendations no longer add unexpected height or margins to the dashboard widgets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100