nextcloud / nextcloud/recognize

Don't Delete Clusters of a Removed Person

Open
#606 5 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
699
Forks
68
Avg merge
1d 4h
Merged PRs (30d)
5

Description

Describe the feature you'd like to request

When a cluster is removed by the user via the "Remove Person" action, the cluster disappears from the oc_recognize_face_clusters table - so I think it is permanently deleted.

What is to stop a Person in that cluster from being recreated in a new cluster if the Face Recognition is toggled off and back on, and the faces are re-detected and queued up again? I think in this case a new cluster is created again with that same Person whose cluster was removed. Unfortunately, toggling off/on is inevitable during troubleshooting and working out bugs.

It may be better to maintain the cluster state and instead hide it. New images of the "Removed Person" would also not generate a new cluster - they would just be added to the hidden cluster. This also then may benefit from a 'review / approve' process to be sure that unintended faces/images aren't added to hidden clusters without ever knowing about it.

It would also be nice to be able to view and manage a hidden "Person", but this part may be a Photos App / Memories App feature.

Thanks,
Brian

Describe the solution you'd like

I would like a new cluster to not be generated in the case that the user has already performed the Remove Person function despite whether the Face Recognition feature has been toggled off/on or if a new image of the undesired Person is added to Nextcloud.

Describe alternatives you've considered

Manually delete the clusters of the undesired Person any time the Face Recognition feature is toggled off/on or a new image of the undesired Person is added to Nextcloud.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by tracing the Remove Person action and the oc_recognize_face_clusters table, then follow cluster creation after face recognition is toggled off and on. Done means removed people remain identifiable as hidden clusters and new detections do not create duplicate clusters.

Written by the indexing model from the issue text.

Assessment

Tech stack
machine-learning, php
Domain
backend, machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.