nextcloud / nextcloud/previewgenerator

Preview generation stops on images/files that error

Open
#142 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
PHP
Stars
520
Forks
55
PR merge metrics
No merged PRs in 30d

Description

manatails@cloud:/var/www/nextcloud$ sudo -u www-data php /var/www/nextcloud/occ -vvv preview:generate-all
2018-11-24T15:43:25+00:00 Generating previews for /manatails/files/InstantUpload/Camera/20181121_213210.jpg
2018-11-24T15:43:26+00:00 Generating previews for /manatails/files/InstantUpload/Camera/20181122_102545.jpg
2018-11-24T15:43:26+00:00 Generating previews for /manatails/files/InstantUpload/Camera/20181122_102826.jpg
2018-11-24T15:43:27+00:00 Generating previews for /manatails/files/InstantUpload/Camera/20181122_133633.jpg
2018-11-24T15:43:27+00:00 Generating previews for /manatails/files/InstantUpload/Camera/20181122_220709.jpg
2018-11-24T15:43:28+00:00 Generating previews for /manatails/files/InstantUpload/IMG_20180807-092858.jpg
manatails@cloud:/var/www/nextcloud$

Same image makes the following log with stock gallery app: imagecreatefromjpeg(): gd-jpeg: JPEG library reports unrecoverable error: Unsupported marker type 0xb3 at /var/www/nextcloud/lib/private/legacy/image.php#560

Preview generation should not stop, but skip unsupported images. In current state one panoramic image in the folder can render whole plugin useless.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the preview:generate-all command and the image handling reported at lib/private/legacy/image.php#560. Reproduce the run with an unsupported image and verify that preview generation continues past it; done means the bad image is skipped and later files are still processed.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.