Feature request: Add credential label to error message if it is corrupted
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 823
- Forks
- 117
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 8
Description
User type: Logged-in
User level: Beginners
Description
Add corrupted credential label when invalid to decrypt
Benefit / value
When a credential is corrupted, the notification error.decrypt is shown to the user.
It would really help if the label was displayed in the notification
Risk / caveats
Handle multiple credentials corrupted ?
Sponsorship
Change this line to
NotificationService.showNotification($translate.instant('error.decrypt') + ': ' + _credential.label, 5000);
(untested)
Are you a developer willing to implement this feature?: yes, if someone lead me to credential storage so I can corrupt them to test.
Can you sponsor the development of this feature or do you know someone who can?: no
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in js/app/controllers/credential.js around line 78 and trace how the credential label is available when decryption fails. Verify the notification includes the corrupted credential's label, and consider the issue's question about handling multiple corrupted credentials when checking the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100