Export should escape quote characters used in CSV
Open
Nobody has claimed this yet.
bug
Import/Export related
needs testing
- Dominant language
- JavaScript
- Stars
- 823
- Forks
- 117
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 8
Description
Bug report
Steps to reproduce
- Add passwords with
". - Export as CSV.
Expected behaviour
Special characters such as ", which may clash with the csv format should be exported.
Actual behaviour
It does not do so…
Configuration
Passman version: 2.1.4
Web server: nginx
Database: MySQL
PHP version: 7.0
cloud server: Nextcloud
cloud version: 12
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name a file or test. Reproduce the CSV export with a password containing a quote, then locate the export entry point and inspect the generated field quoting. Done means exported CSV preserves quote characters and can be parsed correctly by a CSV reader.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, mysql, php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100