nextcloud / nextcloud/passman

Sharing, unsharing and re-sharing is not working correctly

Open
#349 11 comments 0 reactions 1 assignee View on GitHub

@animalillo is already working on this.

Since Aug 9, 2017.

bug
Dominant language
JavaScript
Stars
823
Forks
117
Avg merge
1d 21h
Merged PRs (30d)
8

Description

Bug report

Unshared credentials cannot be shared again by Alice, moreover they are (somehow) duplicating password entries on Bob's side (cf. Screenshots).

Steps to reproduce
  1. Alice unshares a credential -> this disappears correctly on Bob's (the receiver) side.
    image
    image

  2. Alice tries to share the credential again, seems to work at first glance. If Alice wants to leave the share dialog the "this will corrupt the credential" error message appears
    image
    image

  3. On Bob's side the credential does not appear again, but suddenly an other entry is listed twice. If Bob selects the duplicate entry both entries are highlighted as selected (they only seem to be doubled in the view):
    image

  4. Alice cannot press the "unshare" button again:
    image

  5. If Alice tries to share the credential again, the share process is listed as pending, but sharing to Bob did not work.
    image

Expected behaviour

If Alice presses the "unshare" button at a certain credential -> the entry disappears on Bob's side
If Alice presses "share" again -> Bob's side receives a notification for the shared credential
In Bob's vault the shared credential should appear
On both sides the share icons for the credential are update

Actual behaviour

The unshare button deletes the credential on Bob's side -> that's correct
A next share of Alice leads to an incomplete share state -> a corruption error appears on Alice's side and Bob gets duplicate entries in his vault
On Alice's side neither sharing nor unsharing is working anymore.
On Bob's side the shared credential is not listed

Configuration

Operating system:
Ubuntu 16.04 on server and client side

Browser:
Tested with Chrome Version 60.0.3112.78 (Official Build) (64-bit) and Firefox 54.0 (64-bit)

Passman version:
Version: 2.1.4

Database:
MySQL 5.7.19-0ubuntu0.16.04.1

PHP version:
PHP-FPM 7.0.18-0ubuntu0.16.04.1

cloud server: Nextcloud
Nextcloud 12


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.