nextcloud / nextcloud/passman

Somtimes Password generator settings ignored

Open
#347 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue
Dominant language
JavaScript
Stars
823
Forks
117
Avg merge
1d 21h
Merged PRs (30d)
8

Description

Bug report

Steps to reproduce

Basically exactly the same issue as in your addon https://github.com/nextcloud/passman-webextension/issues/150, only that it happens in the web interface too.

  1. Change settings in vault.
  2. Add a new entry and click on the 🔄 icon.

Strangely, when I clicked on the same icon again, it worked. So maybe a race condition or so here. (the settings not yet decrypted?)

So do that test in a vault with many password and add the new entry while the main screen still shows it's loading icon.

Expected behaviour

Use settings.

Actual behaviour

Ignores settings.

Configuration

Operating system: Linux

Browser: FF 54.0.1

Passman version: 2.1.4

PHP version: 7

cloud server: Nextcloud

cloud version: 12


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in a vault with many passwords: change the generator settings, add an entry while the main screen is still loading, and click the generate icon. Trace the web interface's password generator and compare its first use with the second; done means the configured settings are applied on the first click.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.