nextcloud / nextcloud/office

Dependabot PRs against main fail CI (NPM build) without a manual /compile

Open
#112 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6
Forks
1
Avg merge
1d 3h
Merged PRs (30d)
10

Description

Every open Dependabot PR targeting `main` fails the `NPM build` check's "Check build changes" step (e.g. #94, bumping axios). Dependabot only touches `package.json`/`package-lock.json` — it never runs `npm run build`, so the committed `js/`/`css/` bundle goes stale relative to the new dependency tree, and the workflow's post-build `git status --porcelain` diff check fails.

This is specific to `office` being a shipped, non-appstore app: compiled assets have to live in git (see #9, "for shipping the app we need to have compiled assets in the repo"), unlike a typical App Store app where the store's own pipeline builds at packaging time and contributors keep `js/`/`css/` out of the repo entirely.

Fix per PR: comment `/compile` (the `command-compile.yml` bot) before merging, so it recompiles and commits fresh assets. This needs to happen on every dependency-bump PR against `main` (and `stable34`), not just source PRs.

Worth considering as a follow-up: have Dependabot (or a scheduled job) auto-comment `/compile` on its own PRs so this isn't a manual step every time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the NPM build workflow and command-compile.yml, then inspect how Dependabot PRs and the /compile bot interact with generated js/ and css/ assets. Reproduce the Check build changes failure on a dependency-bump PR; done means dependency PRs targeting main and stable34 can pass without a manual compile comment while committed assets remain current.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, javascript, node.js
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.