nextcloud / nextcloud/notify_push
dont try running the (inexistent) rust binary when installing the nextcloud app if os/arch doesnt match
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 344
- Forks
- 64
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 5
Description
i'm making a port for notify_push rust binary on OpenBSD/amd64, and when installing the nextcloud app, apparently its install procedure tries running the binary (which is only shipped for linux anyway):
$ php-7.3 ./nextcloud/occ app:install notify_push
sh: /var/www/nextcloud/apps/notify_push/bin/amd64/notify_push: not found
notify_push 0.1.7 installed
sh: /var/www/nextcloud/apps/notify_push/bin/amd64/notify_push: not found
sh: /var/www/nextcloud/apps/notify_push/bin/amd64/notify_push: not found
notify_push enabled
maybe the script should check for the operating system/arch to make sure the binary exists ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the php-7.3 ./nextcloud/occ app:install notify_push path and the installation logic that invokes /var/www/nextcloud/apps/notify_push/bin/amd64/notify_push. Confirm how installation behaves when that binary is unavailable on OpenBSD/amd64; done means installation and enabling no longer attempt to run a nonexistent binary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, rust
- Domain
- backend, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100