nextcloud / nextcloud/notify_push

1.3.1 breaks availability monitoring

Open
#692 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
344
Forks
64
Avg merge
2d 10h
Merged PRs (30d)
5

Description

I'm using Uptime Kuma to check for the healthiness and correctness of my notify_push setup. It involves reverse proxies and Redis, and there have been instances where a configuration change broke my setup and the monitor outlined below caught it instantly.

The monitor is a simple HTTP request (using Uptime Kuma, but this is unrelated):

$ curl https://nc.example.com/push/test/remote/1.2.3.4
1.2.3.4

The Uptime Kuma config also verifies 1.2.3.4 is returned.

With notify_push 1.3.1 in place, this request is now guarded by a token:

$ curl https://nc.example.com/push/test/remote/1.2.3.4
Missing request header "token"

I prefer to keep this simplistic but effective test. Uptime Kuma does not support executing arbitrary binaries like the provided test_client.

My suggestion is to add a configuration value that defines the value of a "test-only" token to be passed in the HTTP header.

Server configuration

Web server: Apache

Nextcloud version: 33

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the /push/test/remote/{address} endpoint and the request-token validation, then inspect how server configuration is defined. Done means a configured test-only token allows the Uptime Kuma HTTP check to receive the address while requests without appropriate authentication remain protected.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.