nextcloud / nextcloud/notify_push

Self test fails, probably due to sharding?

Open
#622 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
344
Forks
64
Avg merge
2d 10h
Merged PRs (30d)
5

Description

On our daily LTD:

1a60486d2be6:/var/www/html$ ./occ notify_push:self-test -vvv
✓ redis is configured
✓ push server is receiving redis messages

In JoinCondition.php line 129:
                                                                                
  [OC\DB\QueryBuilder\Partitioned\InvalidPartitionedQueryException]             
  join condition for filecache needs to explicitly refer to the table by alias  
                                                                                

Exception trace:
  at /var/www/html/lib/private/DB/QueryBuilder/Partitioned/JoinCondition.php:129
 OC\DB\QueryBuilder\Partitioned\JoinCondition::parseSubCondition() at /var/www/html/lib/private/DB/QueryBuilder/Partitioned/JoinCondition.php:81
 OC\DB\QueryBuilder\Partitioned\JoinCondition::parse() at /var/www/html/lib/private/DB/QueryBuilder/Partitioned/PartitionedQueryBuilder.php:217
 OC\DB\QueryBuilder\Partitioned\PartitionedQueryBuilder->join() at /var/www/html/lib/private/DB/QueryBuilder/Partitioned/PartitionedQueryBuilder.php:204
 OC\DB\QueryBuilder\Partitioned\PartitionedQueryBuilder->innerJoin() at /var/www/html/apps/notify_push/lib/SelfTest.php:225
 OCA\NotifyPush\SelfTest->getStorageIdForTest() at /var/www/html/apps/notify_push/lib/SelfTest.php:77
 OCA\NotifyPush\SelfTest->test() at /var/www/html/apps/notify_push/lib/Command/SelfTest.php:46
 OCA\NotifyPush\Command\SelfTest->execute() at /var/www/html/3rdparty/symfony/console/Command/Command.php:326
 Symfony\Component\Console\Command\Command->run() at /var/www/html/3rdparty/symfony/console/Application.php:1078
 Symfony\Component\Console\Application->doRunCommand() at /var/www/html/3rdparty/symfony/console/Application.php:324
 Symfony\Component\Console\Application->doRun() at /var/www/html/3rdparty/symfony/console/Application.php:175
 Symfony\Component\Console\Application->run() at /var/www/html/lib/private/Console/Application.php:187
 OC\Console\Application->run() at /var/www/html/console.php:90
 require_once() at /var/www/html/occ:33

notify_push:self-test

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with apps/notify_push/lib/SelfTest.php around getStorageIdForTest() and its join at line 225, then read lib/private/DB/QueryBuilder/Partitioned/JoinCondition.php around line 129. Run occ notify_push:self-test -vvv to reproduce the InvalidPartitionedQueryException. Done means the self-test completes without the partitioned-query failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.