nextcloud / nextcloud/notify_push

Seems to leak file handles

Open
#560 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
344
Forks
64
Avg merge
2d 10h
Merged PRs (30d)
5

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce
  1. Enable + setup notify_push app
  2. Open files immediately increases
Expected behaviour

The number of open files should mostly remain unchanged.

Actual behaviour

After enabling the notify_push app, the number of open files on my Nextcloud server(s) is skyrocking:

Image

Restarting php-fpm causes the number of open files to return to normal (but only for a short amount of time).

Server configuration

Web server: Apache HTTPD

Database: MySQL

PHP version: 8.3

Nextcloud version: 30.0.5

Excerpts from lsof
# most open files are related to php-fpm
lsof | grep php-fpm | wc -l
21940

# redis seems to play a part too (runs on the same machine)
lsof | grep redis-ser | wc -l
4650

# a relatively large number of TCP connections
lsof | grep TCP | wc -l
10692

# most of those TCP connections are redis?
lsof | grep TCP | grep redis | wc -l
4679

# of course, many libraries are referenced
lsof | grep lib64 | wc -l
74546

My first assumption is that notify_push may leak redis connections, maybe they are not properly closed or they do not expire soon enough.

Browser

browser seems to be unrelated

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are identified. Start by reproducing the issue with the notify_push app enabled, then use lsof to compare php-fpm, Redis, and TCP connection counts over time. Done means open-file and connection counts remain stable instead of rising until php-fpm is restarted.

Written by the indexing model from the issue text.

Assessment

Tech stack
apache, mysql, php, redis, rust
Domain
backend, databases, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.