nextcloud / nextcloud/notify_push
Redis : don’t use dbindex if cluster mode
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 344
- Forks
- 64
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 5
Description
Hello,
I made a mistake in my configuration and let a dbindex setting for the redis config, but as I am using a Redis cluster, there is no multiple databases so I got this failure:
Failed to setup redis subscription: Redis server refused to switch database- ResponseError
Redis server disconnected, reconnecting in 1s
Nextcloud does not complain as they behave differently between cluster or normal mode (see https://github.com/nextcloud/server/blob/master/lib/private/RedisFactory.php#L79).
I think that notify_push should do the same.
(obviously, I removed the dbindex setting and it works now)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the Redis subscription setup that produces the reported database-switch failure, then compare its configuration handling with the linked Nextcloud RedisFactory behavior. Verify that dbindex is ignored for Redis cluster mode while normal mode retains its existing behavior, and confirm the subscription no longer attempts the invalid database switch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- redis, rust
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100