nextcloud / nextcloud/notify_push

Nextcloud in a subfolder, wrong Proxy directives/missing information in README.md

Open
#198 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation
Dominant language
Rust
Stars
344
Forks
64
Avg merge
2d 10h
Merged PRs (30d)
5

Description

I have a nextcloud instance installed in a subfolder (url looks like this: https://*domain*.*tld*/nc)

  • Ubuntu18.04.6 LTS
  • Apache/2.4.54
  • php8.0-fpm
  • MariaDB 10.5.9
  • Redis server 4.0.9
  • Nextcloud 25.0.1
  • Client Push (notify_push) 0.5.0

config/config.php contains:

'htaccess.RewriteBase' => '/nc',
'overwrite.cli.url' => 'https://*domain*.*tld*/nc',

I did the setup with occ notify_push:setup
The generated sytemd service file inputs were correct, the Environment Variable NEXTCLOUD_URL was in the right form ending on /nc but then it gave me the wrong ProxyPass/ProxyPassReverse directives for Apache:

ProxyPass /push/ws ws://127.0.0.1:7867/ws
ProxyPass /push/ http://127.0.0.1:7867/
ProxyPassReverse /push/ http://127.0.0.1:7867/

Since the path (/push/) must be preceded by the subfolder (in my case /nc, wich results in /nc/push/), the directives should look like this:

ProxyPass /nc/push/ws ws://127.0.0.1:7867/ws
ProxyPass /nc/push/ http://127.0.0.1:7867/
ProxyPassReverse /nc/push/ http://127.0.0.1:7867/

to make the magic happen.

Since occ notify_push:setup recognized the correct URL with subfolder for the NEXTCLOUD_URL environment variable, I also expected the proxy directives to be correct. I was confused and couldn't imagine that the script would suggest wrong proxy directives. So I lost quite a bit of time trying to find the error elsewhere. I then had to make the detour via the Apache manuals and had to try around a bit. This should be easy to fix for future versions.
At least an entry in the README.md whoul be great.

[Edited]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the occ notify_push:setup entry point and README.md, using the reported /nc configuration and Apache ProxyPass directives as the reproduction case. Check why a subfolder appears in NEXTCLOUD_URL but not in the suggested proxy paths. Done means the generated or documented directives correctly include the subfolder, with the README explaining the required setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
apache, rust
Domain
documentation, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.