nextcloud / nextcloud/notify_push
should canonicalize IPv6 before testing trusted_proxies
Open
Nobody has claimed this yet.
bug
- Dominant language
- Rust
- Stars
- 344
- Forks
- 64
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 5
Description
oc notify_push:setup fails when trusted_proxies is not in exactly the same string received in http headers. For instance x:y:z::e is treated as different as x:y:z:0::e
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the oc notify_push:setup handling for trusted_proxies and trace where proxy addresses from HTTP headers are compared. Verify the IPv6 parsing or normalization path, then confirm that equivalent IPv6 forms such as x:y:z::e and x:y:z:0::e are treated as the same trusted proxy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100