nextcloud / nextcloud/notify_push
use gethostbyname for dynamic trusted_proxies (like php of nextcloud does)
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 344
- Forks
- 64
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 5
Description
Hi, I have setup all correctly, but I get:
push server is not a trusted proxy, please add '172.22.1.1' to the list of trusted proxies or configure any existing reverse proxy to forward the 'x-forwarded-for' send by the push server.
As you can see, is 172.22.1.1 a dynamic ip from docker, I use multiple docker-compose files and and multiple networks (dynamic ips), is there any way to dynamically. Setting the ip of this docker network to static would make it less flexible, so something like gethostbyname would be great, if it would work also for notify_push:
https://github.com/nextcloud/documentation/issues/7005#issuecomment-845993541
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by locating trusted_proxies handling in notify_push and review the linked Nextcloud discussion about dynamic resolution. Done means Docker-assigned proxy addresses can be handled without static IP configuration; verify against the reported 172.22.1.1 setup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, docker-compose, rust
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100