nextcloud / nextcloud/notifications
Do not allow dismissing of notifiations with actions
Open
Nobody has claimed this yet.
enhancement
feature: backend 🛠️
- Dominant language
- JavaScript
- Stars
- 153
- Forks
- 67
- Avg merge
- 15h 3m
- Merged PRs (30d)
- 96
Description
If a notification has actions it should not be allowed to be dismissed.
See:
For now I would say we should remove the X because there are actions.
For future work we could consider having types of buttons. And if you have a 'reject' button then the X defaults to that?
CC: @nickvergessen
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the notification UI described in the issue and reproduce the screenshot scenario for a notification that has actions. The change is done when notifications with actions no longer display the dismiss X; the issue does not name a file or test to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100