nextcloud / nextcloud/notifications
Temporary state TokenPasswordExpiredException deletes push token permanently
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 153
- Forks
- 67
- Avg merge
- 15h 3m
- Merged PRs (30d)
- 96
Description
As per commit message I'm not sure whether the behaviour is correct, but at least it's the same as on 27 again.
I think this could really explain vanished push tokens we experienced in the past
Originally posted by @nickvergessen in https://github.com/nextcloud/notifications/issues/1827#issuecomment-1959440576
That being said, that would explain why some people loss their push hashes... if the password was temporarily invalid, we wiped the push token in 27 and before 🤔
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pull request 1828 and its commit message, then trace how TokenPasswordExpiredException is handled and compare the behavior with version 27. Done means establishing whether a temporarily invalid password should permanently delete the push token and recording or implementing the agreed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100