nextcloud / nextcloud/notifications

Cache informaton about Talk desktop usage

Open
#1,769 3 comments 0 reactions 1 assignee View on GitHub

@nickvergessen is already working on this.

Since Jan 9, 2024.

1. to develop enhancement feature: backend 🛠️ performance
Dominant language
JavaScript
Stars
153
Forks
67
Avg merge
15h 3m
Merged PRs (30d)
96

Description

Steps to reproduce
  1. Enable the app
  2. Trigger operations that cause a notification
Expected behaviour

Lean datatabase usage.

Actual behaviour

Excessive database usage for information that changes rarely. On my personal instance with fairly little activity the name lookup in oc_authtoken is the second most executed query on the authtoken table. Details are found in https://github.com/nextcloud/server/issues/42574.

https://github.com/nextcloud/notifications/blob/27a3784b7456cde89f0d751e8c3e6507397c571c/lib/Service/ClientService.php#L41-L65

We can cache this information, even if it's just for a few minutes.

Server configuration

Operating system:

Web server:

Database:

PHP version:

Nextcloud version: 26.0.9

Where did you install Nextcloud from:

Signing status:

Login as admin user into your Nextcloud and access
http://example.com/index.php/settings/integrity/failed 
paste the results here.

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or 

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Client configuration

Browser:

Operating system:

Logs
Nextcloud log (data/nextcloud.log)
Insert your Nextcloud log here
Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log 
c) ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.