nextcloud / nextcloud/notes

Multiple notifications are triggered with activity app

Open
#1,381 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug need to reproduce
Dominant language
JavaScript
Stars
738
Forks
162
Avg merge
6h 2m
Merged PRs (30d)
35

Description

If the activity app is enabled, each modifiaction is registered as an individual activity. This causes the notification app to going havoc if you change a shared note in regular but short intervals.
Concrete example: A shared shopping list with checkboxes can be checked in the app or the web frontend while shopping. This causes me to see like 20 to 50 notifications I have to drop in order to see the important ones.

Steps to reproduce

  1. Have a NC instance with activity and notification app enabled
  2. Have file notifications enabled in feed (and optionally as mail)
  3. Share the notes folder of user A with user B
  4. As user B set storage backend to the shared folder
  5. As user B open a note (or create one) and modify it
  6. Wait a bit or close the note
  7. Continue writing
Expected behaviour

The user A is informed that the file has changed.

Actual behaviour

Each change is represented as a file written thus adding multiple notifications to the list.

Screenshots

If applicable, add screenshots to help explain your problem.
image

Server

Please complete the following information.

  • Notes app version: master (4b3d4d)
  • Nextcloud version: master (dfa994e)
  • OS: Archlinux/Docker
  • Web server: Apache
  • PHP version: 8.1.29
  • Database: MariaDB

Nextcloud configuration:

``` { "system": { "debug": true, "profiler": true, "apps_paths": [ { "path": "\/var\/www\/html\/apps", "url": "\/apps", "writable": false }, { "path": "\/var\/www\/html\/apps-extra", "url": "\/apps-extra", "writable": false }, { "path": "\/var\/www\/html\/apps-shared", "url": "\/apps-shared", "writable": false }, { "path": "\/var\/www\/html\/apps-writable", "url": "\/apps-writable", "writable": true } ], "allow_local_remote_servers": true, "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "1025", "skeletondirectory": "\/skeleton", "setup_create_db_user": false, "loglevel": 2, "log_query": false, "query_log_file": "\/shared\/log\/querylog-nextcloud.log", "query_log_file_requestid": "yes", "diagnostics.logging": false, "diagnostics.logging.threshold": 0, "log.condition": { "apps": [ "diagnostics", "admin_audit" ] }, "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "localhost", "nextcloud", "nextcloud.local", "192.168.21.6", "localhost" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "31.0.0.3", "overwrite.cli.url": "http:\/\/nextcloud.local", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "updater.release.channel": "git", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "lookup_server": "", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "memcache.local": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "app_install_overwrite": [ "calendar", "calendar_resource_management", "event_update_notification" ] } } ```

Client

Please complete the following information.

  • Browser (incl. version): Firefox 130.0
  • OS: Archlinux

Log files

Add relevant parts of your nextcloud.log and/or your browser's JavaScript console here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the activity app and notification app behavior triggered by modifications to shared notes, following the reproduction steps with activity and file notifications enabled. Confirm that repeated edits produce multiple notifications, then verify that a note changed in short intervals results in the expected consolidated notification behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.