Deletion of single shared note is not possible
Open
Nobody has claimed this yet.
1. to develop
bug
feature: backend
feature: sharing
help wanted
- Dominant language
- JavaScript
- Stars
- 738
- Forks
- 162
- Avg merge
- 6h 2m
- Merged PRs (30d)
- 35
Description
Steps to reproduce:
- $USER1 shares a single file to $USER2
- $USER2 moves that shared file to the folder
/Notes/ - $USER2 opens the notes app which lists the shared note
- When clicking the delete button for that note, a "NotPermittedException" is thrown.
Fix:
Instead of deleting the file, the app should "unshare" the file, like it's done in the files app.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Notes app's delete action and compare it with the Files app behavior for shared files. Reproduce the NotPermittedException with a single shared note moved to /Notes/, then verify that deleting it unshares the file instead of removing it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100