nextcloud / nextcloud/notes

Notifications on changed notes are not superseeded

Open
#1,172 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug need to reproduce
Dominant language
JavaScript
Stars
738
Forks
162
Avg merge
6h 2m
Merged PRs (30d)
35

Description

Please make a clear and concise description of what the bug is.

Steps to reproduce

  1. Have two users A and B with access to a NC instance
  2. Share a folder (e.g. Notes) from B to A
  3. On B's settings enable notifications via mail/feed on changes to notes/files.
  4. Create multiple change events using user A on some notes (multiple changes in the same note)
Expected behaviour

User B gets notified about an updated file as notification. The same vice-versa.

Actual behaviour

User B is bombed with notifications as every change is transferred into a notification.

E.g. if user A is on shopping tour and just checking the todo list entries, this will trigger dozens of notifications for user B.

Server

Please complete the following information.

  • Notes app version: 4.5.1
  • Nextcloud version: 23.0.3
  • OS: Archlinux
  • Web server: Apache as reverse proxy + apache
  • PHP version: 8.0
  • Database: mariadb 10.5.15

I know this is dated and should be updates soon. Nevertheless, I have the same problem in other instances.

Nextcloud configuration:

``` { "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "www2.wolf-stuttgart.net", "nextcloud.christian-wolf.click" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "overwrite.cli.url": "https:\/\/nextcloud.christian-wolf.click\/nextcloud", "dbtype": "mysql", "version": "23.0.3.2", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "updater.release.channel": "stable", "maintenance": false, "htaccess.RewriteBase": "\/nextcloud", "theme": "", "loglevel": 0, "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "enable_previews": true, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpauth": 1, "mail_sendmailmode": "smtp", "mail_smtpport": "587", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "mail_smtpsecure": "tls", "has_rebuilt_cache": true, "mysql.utf8mb4": true, "memcache.local": "\\OC\\Memcache\\APCu", "memcache.distributed": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "app_install_overwrite": [ "groupfolders" ], "default_language": "de", "data-fingerprint": "cf50eebf679c181ddf2cb23323eac0db", "default_phone_region": "DE", "localstorage.allowsymlinks": true } } ```

Client

Please complete the following information.

  • Browser (incl. version): Firefox 116.0.3 or Android app
  • OS: Win/Linux/Android of various versions

Log files

Add relevant parts of your nextcloud.log and/or your browser's JavaScript console here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with two users, a shared folder, and multiple changes to the same note, then inspect how mail and feed notifications are generated. Done means repeated changes to one note are consolidated or superseded instead of producing a separate notification for every change.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.