Unable to mark as favorite

This issue respects the following points:

• I have read the FAQ
• I have searched for existing issues
• The issue affects the Notes Android app, neither the Notes server app nor the Nextcloud Android app.

Describe the bug

1. Go to Nextcloud notes app
2. Mark a note as Favorite (either by pressing on the star, or by entering the note and going to the three dot menu)
3. The star is not highlighted and the note does not appear in the list of favorites

Expected behavior

1. The 'favorite' star is highlighted
2. The note appears at the top of the notes list, where the favorites are listed and under the 'Favorites' category

Notes Android version

35.0.0

Notes server version

??

Nextcloud Android version

35.0.0

Nextcloud version

34.0.0

Device

Fairphone 5

Android Version

15

App Store

• Google Play Store
• F-Droid
• Huawei App Gallery

Stacktrace

App Version: 35.0.0
App Version Code: 350000090
App Flavor: fdroid

Files App Version Code: 350000090 (PROD)

---

OS Version: 5.4.300-qgki-g148ded19c625(1786725181)
OS API Level: 35
Device: FP5
Manufacturer: Fairphone
Model (and Product): FP5 (FP5)

---

java.lang.Exception: Network connection failed. Please check your internet connection and server URL.[com.nextcloud.android.sso.api.AidlNetworkRequest.performNetworkRequestV2(AidlNetworkRequest.java:179), com.nextcloud.android.sso.api.NextcloudAPI.performNetworkRequestV2(NextcloudAPI.java:159), com.nextcloud.android.sso.helper.Retrofit2Helper$1.execute(Retrofit2Helper.java:53), it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.pushLocalChanges(NotesServerSyncTask.java:130), it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.run(NotesServerSyncTask.java:99), java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:524), java.util.concurrent.FutureTask.run(FutureTask.java:317), java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156), java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651), java.lang.Thread.run(Thread.java:1119)]
	at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.pushLocalChanges(NotesServerSyncTask.java:150)
	at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.run(NotesServerSyncTask.java:99)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:524)
	at java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
	at java.lang.Thread.run(Thread.java:1119)

Start in NotesServerSyncTask.java at pushLocalChanges, especially lines 130 and 150, and trace how marking a note favorite is synchronized. Reproduce the steps on the listed Android and Nextcloud versions, then verify that the star is highlighted and the note appears in both favorite lists without the reported network failure.