nextcloud / nextcloud/notes-android

Preview mode adding extra blank line above lists nested inside "loose" lists

Open
#1,837 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
1.1k
Forks
168
Avg merge
1d 17h
Merged PRs (30d)
31

Description

Describe the bug
If a note contains a loose list, and that list contains a nested list, an extra blank line will appear above the nested list in preview mode.

To Reproduce
Steps to reproduce the behaviour:

  1. Create a new note in plain edit mode with the following contents:
Test

- one
  - two
    - three

- four
  1. Switch to preview mode, which will display the list with an extra blank line between "one" and "two" (which, in addition to not matching the CommonMark spec, is also counter-intuitive, since the blank line appears in a different place in preview mode than it does in edit mode)

Expected behaviour
Test

  • one
    • two
      • three
  • four

Smartphone (please complete the following information):

  • Nextcloud Notes-Version (android app): 4.0.0
  • F-Droid or Play Store: F-Droid
  • Android-Version: 10
  • Device: Pixel 3a

Server

  • Nextcloud version: 25
  • Nextcloud Notes version (server app): 4.6.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in preview mode with the Markdown example from the report, then trace the preview rendering entry point for nested lists inside a loose list. Done means the rendered output no longer inserts an extra blank line between the nested list items and matches the expected behavior described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, markdown
Domain
content, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.