nextcloud / nextcloud/notes-android
Preview mode adding extra blank line above lists nested inside "loose" lists
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 168
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 31
Description
Describe the bug
If a note contains a loose list, and that list contains a nested list, an extra blank line will appear above the nested list in preview mode.
To Reproduce
Steps to reproduce the behaviour:
- Create a new note in plain edit mode with the following contents:
Test
- one
- two
- three
- four
- Switch to preview mode, which will display the list with an extra blank line between "one" and "two" (which, in addition to not matching the CommonMark spec, is also counter-intuitive, since the blank line appears in a different place in preview mode than it does in edit mode)
Expected behaviour
Test
- one
- two
- three
- two
- four
Smartphone (please complete the following information):
- Nextcloud Notes-Version (android app): 4.0.0
- F-Droid or Play Store: F-Droid
- Android-Version: 10
- Device: Pixel 3a
Server
- Nextcloud version: 25
- Nextcloud Notes version (server app): 4.6.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in preview mode with the Markdown example from the report, then trace the preview rendering entry point for nested lists inside a loose list. Done means the rendered output no longer inserts an extra blank line between the nested list items and matches the expected behavior described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, markdown
- Domain
- content, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100