nextcloud / nextcloud/nextcloudpi
pm.max_requests should be set
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 2.9k
- Forks
- 318
- PR merge metrics
- No merged PRs in 30d
Description
According to the official Nextcloud server tuning guide, PHP-FPM should be configured with pm.max_requests set, to prevent memory leaks.
I am in a situation where workers consume increasing amounts of memory. I suspect this is to my configuration of the preview generation (enabled HEIC, PDF). I assume it is normal behavior, that workers do not actively free their allocated memory. pm.max_requests solves the problem by limiting worker lifespan.
I suggest to make the value configurable with some reasonable default (e.g., 500).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for the PHP-FPM pool configuration and existing configurable process-manager settings, then trace how values are generated or installed. Add a configurable pm.max_requests value with a reasonable default such as 500, and verify that the resulting PHP-FPM configuration contains it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, devops
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 57/100