nextcloud / nextcloud/nextcloudpi

Protect better agains accidential nc-init

Open
#2,039 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

has-updates
Dominant language
Shell
Stars
2.9k
Forks
318
PR merge metrics
No merged PRs in 30d

Description

Description
Let the user extra confirm the nc-init operation.

Example
Maybe by asking to type something that is unique (i.e. is not saved in the browser auto fill in). Or maybe make the Apply button the color red. But basically, with auto filling on in the browser you are a few clicks away from re-initializing your nextcloudpi (and thus potentially losing data).

Background of this request
I accidentally did an nc-init on my nextcloudpi. This happened because there was some difficulty in updating the letsencrypt ssl certificate, because port 80 was not open.
I wanted to disable https-only. The nc-https-only is just above nc-init:

Image

Accidentally, instead of on nc-https-only, I clicked on nc-init.
I have automatic filling in of the password enabled for many sites, so username and password were pre-filled in:

Image

Because I had been fiddling already a while with settings to try to get the certificate renewed, I did not read the message, but just hit Apply. I agree that there is a clear warning in capitals, but because I went so many times through the screens and clicking Apply previously, it was apparently not enough to grap my attention, and I still accidentally clicked on Apply. Only when I saw the output messages appearing I realized my mistake, that I could not stop or undo any more.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the web interface entries for nc-init and nc-https-only, using the reported control placement and accidental autofill behavior as the starting point. Define a confirmation flow that makes nc-init harder to trigger accidentally, then verify that normal settings changes still work and that the operation cannot proceed without the extra confirmation.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.