nextcloud / nextcloud/nextcloud-talk-recording
`/api/v1/welcome` should indicate it actually is a talk recording server
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 34
- Forks
- 16
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 4
Description
Just happened in the chat:
- Someone had the HPB server also configured as recording server
- The
/api/v1/welcomeendpoint exists on both, so the API worked - It showed the HPB version and only by that I randomly managed to identify it as HPB
We will now add an "invert check" and basically fail the server when the X-Spreed-Signaling-Features header is returned.
But it would be better if a positive X-Nextcloud-Talk-Recording-Features would be introduced, also allowing to check Talk if the service is compatible with what Talk expects from the recording server.
Basically like a capability list, feel inspired by https://github.com/nextcloud/spreed/blob/3ce5c7bdaafeb8f4747f7bc05e60ebd33ada192a/lib/Signaling/Manager.php#L52-L55
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the /api/v1/welcome endpoint and compare its current response with the capability-list pattern in spreed's lib/Signaling/Manager.php at the linked revision. Define how the X-Nextcloud-Talk-Recording-Features response should identify compatible recording servers and verify that Talk can check those capabilities.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100