nextcloud / nextcloud/maps

Implement tests

Open
#9 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
598
Forks
113
PR merge metrics
No merged PRs in 30d

Description

(Aand reopening another issue of yours @Henni :)

#83 fixed phpunit. Now we should also use it to test the php backend.

Tests should be written for:

Controllers:
  • ContactsController
  • DevicesApiController
  • DevicesController
  • FavoritesApiController
  • FavoriteController
  • PageController
  • PhotosController
  • RoutingController
  • TracksController
  • UtlisController
Services:
  • AddressService
  • DevicesService
  • FavoritesService
  • GeophotoService
  • PhotofilesService
  • TracksService

@v1r0x As you implemented a lot of this, maybe you can also start creating tests.

This should either be part of Milestone 0.1 or 0.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the PHPUnit setup from #83 and the existing tests for the completed controllers. Then inspect the unchecked UtilsController and service classes—AddressService, DevicesService, FavoritesService, GeophotoService, PhotofilesService, and TracksService—and add coverage for their relevant behavior. Done means the listed PHP backend components have tests and the PHPUnit suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.