nextcloud / nextcloud/maps

Make metric/imperial a user setting

Open
#412 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
598
Forks
113
PR merge metrics
No merged PRs in 30d

Description

Currently, the metric/imperial option is hard coded in src/script.js. As measurement units can be a personal preference, or a user may have grown up learning one system, but now live in a country which uses another, please consider allowing the user to specify their preference.

Also, en_AU and en_NZ are listed in src/script.js as imperial countries. They most certainly are not and have not been for a long time. Please remove these countries from the imperial list.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/script.js by tracing the hard-coded measurement-unit choice and the en_AU/en_NZ entries in the imperial list. Then identify how a user preference can be stored and applied throughout the existing unit selection flow. Done means users can choose metric or imperial, their preference is used, and en_AU and en_NZ are no longer treated as imperial by default.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.