nextcloud / nextcloud/maps

Allow longer (with more characters) comments of Favorites

Open
#1,658 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement
Dominant language
JavaScript
Stars
598
Forks
113
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.
I use Maps Favorites to save places worth visiting during future trips. The comment field accepts only so many characters. When I want to save more info, I cope by saving a text file in my "Maps" directory of the same name as the Favorite, and note this fact in the Favorite comment text.

Trying to save a Favorite with longer comment results in a silent error — i.e. no user notification other than the lack of "Favorite ___ was saved" toast.
Logs contain:

Level	Application		Message
Error	index			DbalException An exception occurred while executing a query: SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'comment' at row 1

Describe the solution you'd like

  • Allow more characters, say 1000 or 1500? If there's no significant penalty - possibly more.

Describe alternatives you've considered

  • Add char counter with max characters allowed indicated (e.g. "346 / 500 characters") near the comment textarea field.
  • Designate comment character storage space as settable by the instance administrator.
  • Add "Linked file" field — to store more info about the Favorite, but have it easily accessed from the Maps app without needing to find the file manually in the Files app. Alternatively, support Nextcloud's Smart Picker?
How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Maps Favorite comment field and trace saving through the backend to the database column named comment; inspect how the length limit and silent save failure are handled. Done means longer comments can be saved without truncation errors and the behavior is covered by the relevant tests, if present.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend, database
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.