nextcloud / nextcloud/maps

Support Google Contact import (sabre-vobject)

Open
#1,125 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement
Dominant language
JavaScript
Stars
598
Forks
113
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.
I have installed Contacts, Maps and the Google integration app, contacts imported from a VCF file (without using the Google integration) are no problem and will show up on the map as supposed.

Either when im using the Google integration app to import my 319 Google contacts from google directly they still show up in the Contacts app (then the url will contain sabre-vobject). After this path of import when I switch back to Maps it says:

Could not load contacts:

Nextcloud

<div id="nojavascript">
<div>
This application requires JavaScript. <a href="https://www.enable-javascript.com/" target="_blank" rel="noreferrer noopener">Enable JavaScript</a> and refresh this page. </div>
</div>

After deleting the imported Google Contacts, Maps will function normally as before.

Describe the solution you'd like
Should be fine and nice to import contacts directly from Google and also Maps shows up those addresses right?

Describe alternatives you've considered
The alternative way for now is to straight import them with a VCF file, only this file does not include all information from the contacts like their photo.

Additional context
Turn of the group as "don't show" won't have any effect.

Example URL (same contact)

VCF File: https://nextcloud.domainname.nl/index.php/apps/contacts/Alle%20contactpersonen/25ca60fd-d4f7-45c0-abcd-2e92a9521afc~contactpersonen

Google Contacts import: https://nextcloud.domainname.nl/index.php/apps/contacts/Alle%20contactpersonen/sabre-vobject-ef5db8c4-4a0c-4e7f-a8b9-907962a15ff8~Google%2520Contacts%2520import

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure in Maps after importing contacts through the Google integration, then compare it with the working VCF import using the example contact URLs. The work is done when Google-imported contacts load in Maps and their addresses appear normally.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.