nextcloud / nextcloud/mail

S/MIME: Lock Menu: Green lock is shown when message is enc+sign but signature verification fails

Open
#8,080 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug feature:smime security skill:frontend
Dominant language
JavaScript
Stars
1k
Forks
348
Avg merge
12h 28m
Merged PRs (30d)
91

Description

Steps to reproduce
  1. Sign (opaque), encrypt and send an email.
  2. Import the S/MIME certificate of the recipient.
  3. Don't import the CA certificate of the recipients.
  4. Open the mail.
  5. Observe that the lock is green.
Expected behavior

There should be a warning that the signature verification failed.

Ref https://github.com/nextcloud/mail/issues/7962

Actual behavior

The lock is green and no warning about the unverified signature is shown.

20230222_155822

Mail app version

main

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the S/MIME opaque signed-and-encrypted message described in the issue, then inspect the lock menu and signature-verification flow. The fix is complete when a missing recipient CA causes signature verification to be reported as failed rather than showing a green lock without a warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.