nextcloud / nextcloud/mail

S/MIME: Verification Backend: Migrate code to openssl cms module

Open
#8,079 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature:smime
Dominant language
JavaScript
Stars
1k
Forks
348
Avg merge
12h 28m
Merged PRs (30d)
91

Description

Is your feature request related to a problem? Please describe.

This module is supported since PHP 8.0. This requirement was not fulfilled when I started developing S/MIME verification and decryption.

Describe the solution you'd like

Use more modern opnssl cms module.

More context is available on https://security.stackexchange.com/questions/41399/openssl-pkcs7-vs-s-mime

  • PKCS#7 -> S/MIME v3.0 (current implementation)
  • CMS -> S/MIME v3.1 (proposed by this issue)
Describe alternatives you've considered

Leave the code as is. This might break compatibility with newer S/MIME versions in the future.

Additional context

https://github.com/nextcloud/mail/blob/6fcb90796f4d0088d576aa56ada50bcc36b6ffc0/lib/Service/SmimeService.php#L79-L82

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lib/Service/SmimeService.php at lines 79-82, where the current PKCS#7-based S/MIME implementation is referenced. Review the linked context on PKCS#7 versus CMS, then determine the migration scope for verification and decryption. Done means the backend uses the modern OpenSSL CMS module while retaining the intended S/MIME behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.