Mail sending error not visible if tab exited during undo send period
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 348
- Avg merge
- 12h 28m
- Merged PRs (30d)
- 91
Description
Steps to reproduce
- Open the app
- Configure an account
- Compose a new message to an invalid recipient
- Send it
Expected behavior
- Toast shows Sending message and the Undo button.
- Message is added to outbox
- I get an error toast that the message could not be sent
- Message remains in outbox
Actual behavior
- *Toast shows Message sent' and the Undo button
- Message is added to outbox
- I get an error toast that the message could not be sent
- Message remains in outbox
^ I think this is especially bad if the user either closes the tab/browser thinking the message definitely went out, or when they are on another tab and don't notice the error toast.
Mail app version
1.3, 1.4
Mailserver or service
No response
Operating system
No response
PHP engine version
No response
Web server
No response
Database
No response
Additional info
Feeback from @marcoambrosini
Hello, today I ran into something with mail:
- I hit send message
- The toast confirmed that the message was sent
- I found the message in outbox a few hours later with the warning "Message could not be sent"
...meaning that the toast was lying!
I think the text of the toast should be changed into sending message in 3, 2, 1 or whatever but it shouldn't fool me into thinking that a message was sent when it wasn't 😅
cc @jancborchardt @nimishavijay
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the invalid-recipient send flow during the undo period and trace the mail send UI that displays the toast. Check how the toast changes when sending later fails and how the outbox state is presented. Done means the initial notification does not claim the message was sent before delivery succeeds, including when the tab is left open or closed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100