nextcloud / nextcloud/mail

Bulk insert could be faster with indexed instead of named arguments

Open
#6,476 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement performance 🚀
Dominant language
JavaScript
Stars
1k
Forks
348
Avg merge
12h 28m
Merged PRs (30d)
91

Description

Is your feature request related to a problem? Please describe.

Blackfire shows that building the final query of the bulk insert loses some performance when named parameters are fetched.

Describe the solution you'd like

Experiment with indexed parameters instead. POC is at https://github.com/nextcloud/mail/pull/6318.

Describe alternatives you've considered

N/a

Additional context

N/a

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the proof of concept in pull request 6318 and locating the bulk-insert query construction in the repository. Compare indexed and named parameter handling, then use the Blackfire performance scenario described in the issue to evaluate the change. Done means the bulk insert is measurably faster without changing its behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.